Scope Yolo mode to the default agent provider - #828

Scopes "automatic Yolo" behavior to the Settings default agent provider, ensuring /agent-switched providers actively reconcile Yolo off unless they canonically match the default. This fits into the overall agent-pane/runtime-config pipeline by tightening how Terminal computes the desired Yolo state and how WTA applies it during rebinds and hot settings updates.

Changes:

• Thread Yolo intent through agent rebind + hot-config events (including generation fencing / backward compatibility) so WTA applies the resolved Yolo state at the right time.
• Normalize Settings behavior: OpenCode forces Yolo off/disabled; policy blocks persist agentPane.yoloMode=false; Gemini remains conditional; /agent stays scoped to default provider.
• Add/extend UT + WTA tests + ItE2E coverage, plus spec and release-checklist updates.

• Files reviewed: 39/39 changed files
• Comments generated: 16
• Review effort level: Lite

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/cascadia/TerminalSettingsEditor/AIAgentsViewModel.cpp:847

• namespace Reg = ... is declared but never used in this function, which can trigger warnings and is unnecessary noise.

• Files reviewed: 39/39 changed files
• Comments generated: 0 new
• Review effort level: Lite

• Files reviewed: 39/39 changed files
• Comments generated: 2
• Review effort level: Lite

• Files reviewed: 39/39 changed files
• Comments generated: 1
• Review effort level: Lite

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/cascadia/TerminalSettingsEditor/MainPage.cpp:902

• SaveButton_Click normalizes Yolo for an unavailable default provider, but it doesn't also normalize when AllowYoloMode policy is currently blocking Yolo. That can allow saving a clone that still contains agentPane.yoloMode=true even though policy requires persisting false (until a later ReloadSettings pass corrects it). Clearing both cases before writing avoids persisting a policy-invalid value even transiently.

• Files reviewed: 39/39 changed files
• Comments generated: 0 new
• Review effort level: Lite

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/cascadia/TerminalApp/TerminalPage.cpp:2348

• Tab::AgentCurrentId is used as the "actual current provider" input for _ResolveHotAutomaticYoloForAgentBinding (see the agent_config_changed Yolo path), but it’s being set here to the target binding.agentId before the helper has actually rebound. That can temporarily misrepresent the running provider during an in-flight rebind, and can cause hot Yolo updates to be computed for the wrong (not-yet-active) provider.

Consider only updating AgentCurrentId from authoritative status updates (e.g., OnAgentStatusChanged when state == "connected"), and avoid setting it on the outbound rebind request.

• Files reviewed: 39/39 changed files
• Comments generated: 0 new
• Review effort level: Lite

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/cascadia/TerminalApp/TerminalPage.cpp:2412

• agent_config_changed now delivers Yolo updates as per-tab events where yolo_enabled is the resolved desired value for that tab’s current provider. Adding a short comment here would prevent future readers from assuming yoloEnabled is a single window-wide "global default" (especially since defaultAgentId is now part of the change detection).

• Files reviewed: 39/39 changed files
• Comments generated: 0 new
• Review effort level: Lite

• Files reviewed: 39/39 changed files
• Comments generated: 0 new
• Review effort level: Lite