-
Notifications
You must be signed in to change notification settings - Fork 170
Add an optional 'sessionId' parameter to ProtocolMessage#80
Open
EricCornelson wants to merge 1 commit into
Open
Add an optional 'sessionId' parameter to ProtocolMessage #80EricCornelson wants to merge 1 commit into
EricCornelson wants to merge 1 commit into
Conversation
@weinand
weinand
added
the
feature-request
Request for new features or functionality
label
Feb 28, 2020
weinand
commented
Nov 15, 2022
Contributor
Multiplexing sessions and the concept of a sessionId is not part of the DAP spec.
Having a sessionId as an optional property on the ProtocolMessage is not needed and violates the concept of "Separation of concerns".
If some other entity wants to multiplex sessions over a single communication channel it can do so by wrapping a ProtocolMessage in another structure that has a sessionId property.
mtg06001
mtg06001
approved these changes
Mar 13, 2023
LolyPopToyou
LolyPopToyou
approved these changes
Aug 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first step in enabling a "flat session" mode of communication in the protocol (see #79 for more details).