-
Notifications
You must be signed in to change notification settings - Fork 294
ci: deploy docs when overrides/ changes + add manual trigger#656
Open
rain-Brian wants to merge 1 commit into
Open
ci: deploy docs when overrides/ changes + add manual trigger #656rain-Brian wants to merge 1 commit into
rain-Brian wants to merge 1 commit into
Conversation
The Deploy MkDocs site workflow only watched docs/**, mkdocs.yml, and docs-requirements.txt. The theme override (overrides/main.html) holds the JSON-LD, Open Graph, and social-card meta, so overrides-only SEO changes merged to main without triggering a deploy and never went live. Add overrides/** to the path filter, plus a workflow_dispatch trigger for manual redeploys of stranded changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Deploy MkDocs siteworkflow triggers on pushes tomainthat touchdocs/**,mkdocs.yml, ordocs-requirements.txt. The theme overrideoverrides/main.html— which holds the JSON-LD, Open Graph, and social-card meta — is not watched. An overrides-only SEO PR would merge to main but never trigger a deploy, so the change would never go live.Fix
overrides/**to the push path filter, so theme/SEO override changes deploy.workflow_dispatch:trigger, so a stranded change can be redeployed manually without an empty commit.