-
Notifications
You must be signed in to change notification settings - Fork 738
Fix undefined 'notebook' parameter in azpapermill_iterator template - #195
Open
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Open
Fix undefined 'notebook' parameter in azpapermill_iterator template #195Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Conversation
@ArshVermaGit
Arsh Verma (ArshVermaGit)
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The parameter mismatch is correctly fixed, and the verification confirms the template remains valid. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ci/steps/azpapermill_iterator.ymlreferences${{parameters.notebook}}(singular) in its inline script, but the template declaresnotebooks:(plural) in its ownparameters:block, and the only caller (.ci/steps/ADOTrainDeployAMLJob.yml) passesnotebooks:.Referencing an undeclared template parameter makes Azure Pipelines template expansion fail, so this template cannot compile. The fix aligns the
echostatement with the rest of the script, which already loops over${{parameters.notebooks}}.Verification
.ci/steps/azpapermill.ymldeclaresnotebook:(singular) and correctly uses${{parameters.notebook}}everywhere — the plural/singular split here is purely a copy/paste artifact.microsoft/AImaster.