-
Notifications
You must be signed in to change notification settings - Fork 738
Fix Issue #128 regarding the images not appearing in markdown docs. - #129
Open
Norbert Cygiert (norbertcygiert) wants to merge 2 commits into
Open
Fix Issue #128 regarding the images not appearing in markdown docs. #129Norbert Cygiert (norbertcygiert) wants to merge 2 commits into
Norbert Cygiert (norbertcygiert) wants to merge 2 commits into
Conversation
Norbert Cygiert (norbertcygiert)
commented
May 14, 2025
Author
@microsoft-github-policy-service agree
ManyaS-Git
Manya Sharma (ManyaS-Git)
approved these changes
Aug 8, 2026
@ManyaS-Git
Manya Sharma (ManyaS-Git)
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified and looks correct — approving.
Checklist confirmed:
- Both images exist in the repo at the resolved paths:
.images/decision_python_scoring.pngand.images/python_training_diag.png(confirmed against themastertree). - From
.docs/python_scoring.md,../.images/decision_python_scoring.pngresolves to<root>/.images/decision_python_scoring.png— correct. - Same for
.docs/python_training.md→../.images/python_training_diag.png. - The fix exactly matches the bug described in issue #128 ("'images' instead of '.images'").
- Bonus: both files now end with a trailing newline (previously
\ No newline at end of file), which is good hygiene.
Minor suggestions (non-blocking):
- This fixes the two files in the issue, but the same
images/vs.images/typo may exist elsewhere in the docs. It may be worth a quick repo-wide grep forsrc="images//](images/(without the dot) and a follow-up PR if any other markdown files are affected. - Consider adding a tiny CI link-checker (e.g.,
markdown-link-check) so broken doc links get caught automatically in future PRs.
Nice minimal fix — thank you.
This was referenced Aug 8, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix, changed the name of the images folder to the correct one, now images appear normally.