-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(logging): allow child loggers to set independent log levels#1077
Open
ThomasFarstrike wants to merge 1 commit intomicropython:master from
Open
fix(logging): allow child loggers to set independent log levels #1077ThomasFarstrike wants to merge 1 commit intomicropython:master from
ThomasFarstrike wants to merge 1 commit intomicropython:master from
Conversation
The handler's level was being set to the root logger's level in basicConfig(),
which prevented child loggers from setting their own levels. This violated the
standard logging architecture where handlers should not filter by level - that's
the logger's responsibility.
Changed handler.setLevel(level) to handler.setLevel(NOTSET) in basicConfig()
so that handlers pass through all messages and let loggers control filtering.
This allows code like:
logger = logging.getLogger("myapp")
logger.setLevel(logging.INFO)
logger.info("message") # Now works correctly
Previously, INFO messages would be filtered out if the root logger was at WARNING.
Fixes: Child loggers unable to log at levels lower than root logger's level
Signed-off-by: Thomas Farstrike <111072251+ThomasFarstrike@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler's level was being set to the root logger's level in basicConfig(), which prevented child loggers from setting their own levels. This violated the standard logging architecture where handlers should not filter by level - that's the logger's responsibility.
Changed handler.setLevel(level) to handler.setLevel(NOTSET) in basicConfig() so that handlers pass through all messages and let loggers control filtering.
This allows code like:
logger = logging.getLogger("myapp")
logger.setLevel(logging.INFO)
logger.info("message") # Now works correctly
Previously, INFO messages would be filtered out if the root logger was at WARNING.
Fixes: Child loggers unable to log at levels lower than root logger's level