-
Notifications
You must be signed in to change notification settings - Fork 1.1k
logging: Add handler param to basicConfig.#1023
logging: Add handler param to basicConfig. #1023greezybacon wants to merge 1 commit intomicropython:master from
handler param to basicConfig. #1023Conversation
stinos
commented
Jun 11, 2025
It seems like a small step to just support handlers then, such that the code should remains compatible with CPython?
greezybacon
commented
Jun 11, 2025
I could do that, yeah. My thought was that for an MCU more than one handler is unlikely, but I agree that compatibility means that everyone feels more comfortable using Micropython.
Josverl
commented
Jun 12, 2025
I agree that handlers = [] is simpler to learn ,
it also means that adding
Logger.addHandler() makes more sense.
CPython allows specifying a list of handlers in the initialization of logging with basicConfig(handlers=<iterable>). This adds similar support to Micropython. It allows to initialize logging with a set of specialized handlers. Signed-off-by: Jared Hancock <jared@greezybacon.me>
9d4e1ae to
25185a5
Compare
@dpgeorge
dpgeorge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice enhancement, but the implementation doesn't work.
We really need some unittests for the logging module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right: handlers is never None unless explicitly passed in. Maybe you meant if not handlers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging is not defined in this scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the default handler (if none specified) is never added?
CPython allows specifying a list of handlers in the initialization of logging with basicConfig(handlers=). This adds similar support but only with a single handler. It allows to initialize logging with a single, specialized handler.