-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change the line parsing and storage approach to reduce the overall line processing time#3975
Draft
Change the line parsing and storage approach to reduce the overall line processing time #3975
Conversation
This was referenced Jan 25, 2026
Closed
Member
Author
JoeKar
commented
Jan 25, 2026
@dmaluka
You should now be able to work directly at performance/rune-lines, in case you find some time to do so. 😉
A lot of work is still present to exchange these LineBytes() and util.CharacterCount() accesses + the stuff I missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The intention came up out of the discussion for #3127.
We realized that the line is processed multiple times as bytes to receive the resulting runes and their count.
This can be significantly reduced by storing already the decoded runes per line while parsing that line the first time. Afterwards this line doesn't need to be decoded again and the count can be accessed by a simple usage of
len().Since this is a huge rework and change of one of the basics it might brake one or more interfaces used by plugins.
The change is still ongoing and a lot of depending functionalities need to be changed. So please expect rebases from time to time.
I created the PR anyway since a lot of very important discussion was already ongoing within #3127 which shall be continued in here to keep the former one clean now.
In case someone else likes to support here then please provide PRs to
performance/rune-linesas base branch and we can apply them.BTW:
make testruns successfully already.This PR will continue #3149.