-
Notifications
You must be signed in to change notification settings - Fork 111
Added example to show Wi-Fi and a subscriber. - #131
Open
AndyBlightLeeds wants to merge 6 commits into
Open
Conversation
Added an example that shows how to use micro-ROS with a publisher and a subscriber with Wi-Fi on an ESP32.
pablogs9
pablogs9
requested changes
Mar 18, 2024
pablogs9
commented
Mar 18, 2024
Member
It would be a good idea to add the build of the examples to the CI procedure. Are you open to contribute this @AndyBlightLeeds ? Do you have experience with Github actions?
I've no time even to build this locally sorry, and it would be great to see that everything is building correctly. Let me know if you can, if not I'm merging this blindly.
AndyBlightLeeds
commented
Mar 18, 2024
Author
I haven't done any GitHub actions for a while. but I'll see if I can add one for the new example this afternoon. I'll let you know how I get on.
AndyBlightLeeds
commented
Mar 18, 2024
Author
Thanks for starting the workflow. I think I have fixed the bug in the publisher example. Hopefully, it will work this time.
AndyBlightLeeds
commented
Mar 18, 2024
Author
I'll take another look at this tomorrow.
The publisher example code was failing due to the first 3 lines of the platformio.ini file being commented out. I can now build that publisher example on my PC, so hopefully this time it will build both examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an example that shows how to use micro-ROS with a publisher and a subscriber with Wi-Fi on an ESP32.