-
Notifications
You must be signed in to change notification settings - Fork 1k
[dbAuth] add pkName to Columnnames if not contained inside 'dbAuth.returnedColumns' #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...turnedColumns'
If you try to change the password and $pkName isn't contained inside 'dbAuth.returnedColumns', dbAuth won't know the id column and returns error:
<b>Warning</b>: Undefined array key "id" in <b>C:\XAMPP\htdocs\api.php</b> on line <b>7978</b><br />
{"code":9999,"message":"Tqdev\\PhpCrudApi\\Database\\GenericDB::updateSingle(): Argument #3 ($id) must be of type string, null given, called in C:\\XAMPP\\htdocs\\api.php on line 7978"}
@maheini
maheini
changed the title
(削除) [dbAuth] add pkName to Columnnames if not specified inside 'dbAuth.returnedColumns' (削除ここまで)
(追記) [dbAuth] add pkName to Columnnames if not contained inside 'dbAuth.returnedColumns' (追記ここまで)
Feb 25, 2022
Well found and implemented. Thank you very much for your contribution.
mevdschee
added a commit
that referenced
this pull request
Feb 26, 2022
Released in v2.13.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to change the password and
$pkNameisn't contained inside'dbAuth.returnedColumns', dbAuth won't know the column containing the id and will returns this error:Warning: Undefined array key "id" in C:\XAMPP\htdocs\api.php on line 7978
{"code":9999,"message":"Tqdev\PhpCrudApi\Database\GenericDB::updateSingle(): Argument #3 ($id) must be of type string, null given, called in C:\XAMPP\htdocs\api.php on line 7978"}