Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Docs configurable usertable fields #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mevdschee merged 2 commits into mevdschee:main from nik2208:Docs_configurableUsertableFields
Feb 17, 2022
Merged

Docs configurable usertable fields #856

mevdschee merged 2 commits into mevdschee:main from nik2208:Docs_configurableUsertableFields
Feb 17, 2022

Conversation

Copy link
Contributor

@nik2208 nik2208 commented Feb 17, 2022

sorry.. this is my first github contribution.. forgot to modify README.md

Copy link
Contributor Author

nik2208 commented Feb 17, 2022

I see only now I could have published on the main pull request for this feature..
mevdschee reacted with thumbs up emoji

@mevdschee mevdschee merged commit a995dd6 into mevdschee:main Feb 17, 2022
@mevdschee mevdschee self-assigned this Feb 17, 2022
@mevdschee mevdschee self-requested a review February 17, 2022 12:36
Copy link
Owner

Well done, thank you!

$password = isset($body->password) ? $body->password : '';
$newPassword = isset($body->newPassword) ? $body->newPassword : '';
$usernameFormFieldName = $this->getProperty('usernameFormField', 'username');
$passwordFormFieldName = $this->getProperty('passwordFormField', 'username');
Copy link
Owner

@mevdschee mevdschee Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'username' should be 'password'

$usernameFormFieldName = $this->getProperty('usernameFormField', 'username');
$passwordFormFieldName = $this->getProperty('passwordFormField', 'username');
$newPasswordFormFieldName = $this->getProperty('newPasswordFormField', 'username');
$username = isset($body->usernameFormFieldName) ? $body->usernameFormFieldName : '';
Copy link
Owner

@mevdschee mevdschee Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$body->usernameFormFieldName should be $body->$usernameFormFieldName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mevdschee mevdschee mevdschee left review comments

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /