-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Conversation
Signed-off-by: Vladyslav Karpenko <klarpen@gmail.com>
PR_URL: metarhia#30 Signed-off-by: Vladyslav Karpenko <klarpen@gmail.com>
KLarpen
commented
Dec 15, 2023
Contributor
Author
The webhook section ready for review @tshemsedinov . Warning about webhooks requesting through the balancer port, that we had discussed at thursday call 133, I had pack as separate commit. So you'll be able to land the section but ask some changes into notice text.
KLarpen
commented
Dec 18, 2023
Contributor
Author
Direct link to the discuss at community call 133 that revealing a situation with webhooks and balancer port: https://youtu.be/2sWbuuuU_MY?t=7304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add "Webhooks" sub section to the API layer: units and endpoints section at LAYERS page. I decided to place it as sub section because on the LAYERS page its content completely lays down into API layer description. That's why direct link to that new subsection hasn't been added into the index of content at README page and not necessary.