Skip to content

Navigation Menu

Sign in
Sign up

Fix repl and other misc code, including test - #211

Open
michalz-zoom wants to merge 6 commits into
maxtaco:iced2 from
michalz-zoom:michalz/fix-repl
Open

Fix repl and other misc code, including test #211
michalz-zoom wants to merge 6 commits into
maxtaco:iced2 from
michalz-zoom:michalz/fix-repl

Conversation

@michalz-zoom

@michalz-zoom michalz-zoom commented Dec 16, 2025
edited
Loading

Copy link
Copy Markdown
  • At some point Node.js repl.rli was deprecated. Properties of 'rli' were already present in 'repl' REPLServer object, so this is a simple change.
  • Fix Buffer constructor calls which are deprecated.
  • Fix other test files, again, mostly Node libraries changing things around (changes in vm.Script, fs.unlink, assert.throws etc.)
  • In Cakefile, be more verbose where the global functions come from ('assert' module - ok, fail etc.), also add a way to run single (or multiple) test files instead of full test suite.

At some point Node.js repl.rli was deprecated. Properties of 'rli'
were already present in 'repl' REPLServer object, so this is a simple
change.
Node.js 'assert' module complains if we try to use assert.throws to
check an exception that is literally Error('error') has a message
'error', saying that it's ambiguous.
We were calling fs.unlink without providing callback, so this test was
failing to clean up its temporary file.
@michalz-zoom michalz-zoom changed the title (削除) Fix repl (削除ここまで) (追記) Fix repl and other misc code, including test (追記ここまで) Dec 17, 2025

Copy link
Copy Markdown
Author

@maxtaco please take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /