forked from jashkenas/coffeescript
-
Notifications
You must be signed in to change notification settings - Fork 59
[iced3] Use source-map-support for stack trace formatting - #206
Merged
Merged
Conversation
Disable cache when installing in source-map-support - we are keeping our own cache, and so does ts-node, so while there is benefit from another cache layer on s-m-s side, this causes problems with anonymous files, or modules that are removed from require.cache and re-required. Using "<anonymous iced3>" instead of "<anonymous>" module.filename when running code that does not have a file name allows iced3 and iced2 to not clash if both are used within one node instance.
@zapu
zapu
changed the title
(削除) Zapu/source map support iced3 (削除ここまで)
(追記) [iced3] Use source-map-support for stack trace formatting (追記ここまで)
Dec 3, 2019
zapu
zapu
commented
Dec 11, 2019
@@ -3,7 +3,7 @@
<head>
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore when reviewing - generated file from documentation/test.html
zapu
zapu
commented
Dec 12, 2019
@@ -11,6 +11,8 @@ path = require 'path'
helpers = require './helpers'
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most important changes are in this file.
maxtaco
maxtaco
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iced3 version
Work in progress
Iced2 version is here: #205