forked from jashkenas/coffeescript
-
Notifications
You must be signed in to change notification settings - Fork 59
Open
Conversation
It was still pulled because it's a sub-depedency, but the way it was installed by latest npm made it impossible to require directly from coffee-script package.
maxtaco
maxtaco
approved these changes
May 11, 2018
@maxtaco
maxtaco
left a comment
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! 👍
zapu
commented
May 11, 2018
Collaborator
Author
I think you need to hit merge as well. Thanks!
zapu
commented
May 11, 2018
Collaborator
Author
ah, but I didn't touch the version string anywhere. please hold
zapu
commented
May 12, 2018
Collaborator
Author
Done! Bumped version and recompiled browser bundle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned out to be an evening project to make the tests pass again on latest node and npm.
PR fixes compilation error during
await foo defer err result, which because of lack of comma is compiled asawait foo(defer(err(result)))anderr(result)is not valid slot. It's so not valid that it even crashes compiler.