-
-
Notifications
You must be signed in to change notification settings - Fork 96
Add support for NaN value #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NaN cannot be checked as equality. This commit add a test based on isNaN
Typescript definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test description confused me.
More concrete wording:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use Number.isNaN to check both Number type and NaN value simultaneously.
- if (typeof lhs === "number" && typeof rhs === "number") { - if (isNaN(lhs) && isNaN(rhs)) return {}; // NaN is equal - } + if (Number.isNan(lhs) && Number.isNan(rhs)) return {}; // NaN is equal
@bdombro
bdombro
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anko you meant to cap the last 'n' --> Number.isNaN
NaN cannot be checked as equality. This commit add a test based on isNaN