MM-68992 - add attribute value masking documentation#9000

Open

pvev wants to merge 2 commits into

v11.9-documentation from

MM-68992-add-attribute-masking-docs

Open

MM-68992 - add attribute value masking documentation #9000
pvev wants to merge 2 commits into
v11.9-documentation from
MM-68992-add-attribute-masking-docs

Conversation

@pvev

@pvev pvev commented May 27, 2026

Copy link

Copy Markdown

Contributor

Summary

Adds attribute value masking documentation

Ticket Link

https://mattermost.atlassian.net/browse/MM-68992

@pvev


 MM-68992 - add attribute value masking documentation

3541fde

@pvev pvev requested review from Combs7th, davidkrauser and esethna

May 27, 2026 10:11

@github-actions

github-actions Bot commented May 27, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA 3541fde

@amyblais amyblais added this to the v11.8.0 milestone

May 28, 2026

@amyblais amyblais added 1: Dev Review 2: Editor Review labels

May 28, 2026

davidkrauser

davidkrauser approved these changes

May 28, 2026

View reviewed changes

@davidkrauser davidkrauser left a comment

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for documenting this. Have a few comments, but pre-approving.

source/administration-guide/manage/admin/abac-channel-access-rules.rst Outdated

.. note::

If a policy rule references attribute values you don't hold, those values appear as ``--------`` and the row is read-only. Test and Delete actions are also disabled for those rows. See :ref:`Attribute value masking <administration-guide/manage/admin/abac-system-wide-policies:attribute value masking>` for details.

@davidkrauser davidkrauser May 28, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for shared_only attributes, right? Should we specify that?

@pvev pvev May 28, 2026

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, better to clarify this.

source/administration-guide/manage/admin/user-attributes.rst

Attribute access modes

-----------------------

Each user attribute has an **access mode** that controls who can see its values when those values appear in access control policies. The access mode is set per attribute and determines whether an admin editing a policy can see the raw attribute values referenced in its rules.

@davidkrauser davidkrauser May 28, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify that these access modes are only available for custom plugins to set?

@pvev pvev May 28, 2026

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that makes sense. Is hard even for us internally to get how this exactly works. Will add a new section briefly explaining this. I will ask you again for feedback once done @davidkrauser 👍

@pvev


 add details about access mode

9f98329

@github-actions

github-actions Bot commented May 28, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA 9f98329

@pvev pvev requested a review from davidkrauser

May 29, 2026 08:08

@pvev

pvev commented May 29, 2026

Copy link

Copy Markdown

Contributor Author

@davidkrauser one quick look to commit 9f98329 🙏

davidkrauser

davidkrauser approved these changes

May 29, 2026

View reviewed changes

@amyblais amyblais removed the 1: Dev Review label

Jun 2, 2026

@pvev

pvev commented Jun 2, 2026

Copy link

Copy Markdown

Contributor Author

@amyblais @marianunez since we are not enabling the FF for this 11.8 release, perhaps we want to hold on this PR so it wont cause confusion on customers.