Search code, repositories, users, issues, pull requests...

https://mattermost.atlassian.net/browse/MM-68319

@mgdelacroix mgdelacroix commented May 7, 2026

Copy link

Copy Markdown

Member

Summary

Fixes three errors in the Integration request timeout config setting documentation:

:configjson: was OutgoingIntegrationRequestsDefaultTimeout — this is the name of an internal Go constant, not the config.json key. The correct key is OutgoingIntegrationRequestsTimeout.
:environment: was MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT (derived from the wrong key). Corrected to MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.
Default value was documented as 3 seconds. The actual default is 30 seconds (set in config.SetDefaults, enforced by IsValid which rejects <= 0).

Ticket Link


 Fix OutgoingIntegrationRequestsTimeout config key name and default value

a80a826

@mgdelacroix mgdelacroix requested review from angeloskyratzakos and Copilot

May 7, 2026 11:16

@mgdelacroix mgdelacroix added the 1: Dev Review label

Copilot started reviewing on behalf of mgdelacroix

May 7, 2026 11:17

View session

@coderabbitai

coderabbitai Bot commented May 7, 2026 •

edited

Loading

Copy link

Copy Markdown

Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

i️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd05cfd4-b1d2-49ab-99e8-f08e7aed0430

📥 Commits

Reviewing files that changed from the base of the PR and between a80a826 and fe96543.

📒 Files selected for processing (1)

source/administration-guide/configure/integrations-configuration-settings.rst

🚧 Files skipped from review as they are similar to previous changes (1)

source/administration-guide/configure/integrations-configuration-settings.rst

📝 Walkthrough

Walkthrough

The documentation updates the integration request timeout setting to use .ServiceSettings.OutgoingIntegrationRequestsTimeout / MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT and changes the documented default from 3 seconds to 30 seconds.

Changes

Integration Request Timeout Configuration

Layer / File(s)	Summary
Configuration Setting Documentation `source/administration-guide/configure/integrations-configuration-settings.rst`	Config directive updated from `.ServiceSettings.OutgoingIntegrationRequestsDefaultTimeout` / `MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT` to `.ServiceSettings.OutgoingIntegrationRequestsTimeout` / `MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT`; feature summary and inline default changed from `3` to `30` seconds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: fixing the config key name and updating the default value for the OutgoingIntegrationRequestsTimeout setting.
Description check	✅ Passed	The description is directly related to the changeset, providing clear context about the three documentation errors being fixed and referencing the relevant ticket.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/outgoing-integration-timeout-docs

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai[bot]

coderabbitai Bot approved these changes

Copilot AI reviewed

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Mattermost documentation for the "Integration request timeout" setting by aligning the documented config.json key name, environment variable name, and default value with the actual server configuration behavior.

Changes:

Fixes the documented config.json key from OutgoingIntegrationRequestsDefaultTimeout to OutgoingIntegrationRequestsTimeout.
Fixes the documented environment variable to MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.
Updates the documented default timeout from 3 seconds to 30 seconds, including the inline config.json example.

source/administration-guide/configure/integrations-configuration-settings.rst Outdated

github-actions Bot commented May 7, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA a80a826


 Fix on a comma

fe96543

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@mgdelacroix mgdelacroix requested a review from Copilot

May 7, 2026 11:27

Copilot started reviewing on behalf of mgdelacroix

May 7, 2026 11:28

View session

Copilot AI reviewed

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

github-actions Bot commented May 7, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA fe96543


 Merge branch 'master' into fix/outgoing-integration-timeout-docs

ec7bb2e

github-actions Bot commented May 11, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA ec7bb2e


 Merge branch 'master' into fix/outgoing-integration-timeout-docs

github-actions Bot commented May 18, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA 0313516

@Combs7th Combs7th added the 2: Editor Review label

May 20, 2026

@Combs7th

Combs7th commented May 23, 2026

Copy link

Copy Markdown

Contributor

@angeloskyratzakos - Can you help give this one a technical review when you're able? Thanks so much in advance!

angeloskyratzakos

angeloskyratzakos approved these changes

Jun 12, 2026

@angeloskyratzakos


 Merge branch 'master' into fix/outgoing-integration-timeout-docs

1e4e40e

github-actions Bot commented Jun 12, 2026

Copy link

Copy Markdown

Contributor

Newest code from mattermost has been published to preview environment for Git SHA 1e4e40e


 Merge branch 'master' into fix/outgoing-integration-timeout-docs