-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add rcsetup_api.rst, fix typo for rcsetup.cycler #7732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that minor sphinx fix. (Other test failures look unrelated.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The length of the **** needs to match that of rcsetup; that's causing a warning from sphinx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still has a typo. cyl was the original name, but then we decided it was ok to collide with the cycler from the cycler package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, can you clarify what you mean by still having a typo? What's the exact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cyler should be cycler
Ugh...bozo mistakes. I looked at cyler for like 15 minutes and still couldn't figure it out
Current coverage is 62.12% (diff: 100%)
@@ master #7732 diff @@
==========================================
Files 174 174
Lines 56028 56028
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
Misses 21223 21223
Partials 0 0 Powered by Codecov. Last update 8279f64...70d4546
Add rcsetup_api.rst, fix typo for rcsetup.cycler
backported to v2.x branch via 3b48809
Addresses #7223