-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Added -j shortcut for --processes=
#7362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am totally in favor of argparse!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we will have to refactor a bit this code, but for now this looks good.
tests.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need no-pep8 and pep8? Seems they are redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's certainly confusing. I think the idea is that '--pep8' means do only PEP8 testing, '--no-pep8' means do everything except PEP8 testing, and leaving both out means test everything including PEP8.
When using argparse, it would be good to add 'help' kwargs to each add_argument call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow... Thanks for the explanation.
I suppose argparse will interfere with nose on --help flag.
Haven't looked at the PR itself but in any case you can prevent argparse from adding a --help with add_help=False (https://docs.python.org/3/library/argparse.html#add-help).
Sure. Added it 👍
This seems to have broken the --with-coverage flag https://travis-ci.org/matplotlib/matplotlib/jobs/173562893
See https://docs.python.org/3/library/argparse.html#nargs for REMAINDER. Any CL args we do not explicitly consume should fall through to nose / pytest (eventually).
milestoned as 2.0.1, but if the backport is at all hard, lets not bother.
Latest commit should fix passthrough flags like --with-coverage
-j shortcut for --processes= (削除ここまで)-j shortcut for --processes= (追記ここまで)
445397a to
7f29efe
Compare
@tacaswell This does not apply cleanly on v2.x. I don't think it is worth bothering with this patch for 2.0. What do you think?
I'll answer: No, just leave it in master.
-j shortcut for --processes= (削除ここまで)-j shortcut for --processes= (追記ここまで)
Addresses #7361.
The argv parsing is a bit naive, but I'm not sure what matplotlib's opinion on
getoptorargparseis.