-
-
Notifications
You must be signed in to change notification settings - Fork 8k
remove check under linux for ~/.matplotlib #7195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dopplershift
merged 3 commits into
matplotlib:master
from
nbrunett:rm_matplotlibrc_check
Oct 3, 2016
Merged
remove check under linux for ~/.matplotlib #7195
dopplershift
merged 3 commits into
matplotlib:master
from
nbrunett:rm_matplotlibrc_check
Oct 3, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you rebase to remove the merge from upstream master into your feature branch?
Otherwise looks good.
The master branch will be the 2.1 release so this is the correct place to open the pull request.
QuLogic
QuLogic
reviewed
Sep 28, 2016
subdirectory is created.
defined, :file:`{HOME}/.config/matplotlib` is generally used on unix-like
systems and :file:`{HOME}/.matplotlib` is used on other platforms, if they are
writable. Otherwise, the python standard library :func:`tempfile.gettmpdir`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say gettempdir.
@nbrunett
nbrunett
force-pushed
the
rm_matplotlibrc_check
branch
from
September 29, 2016 02:49
d39ea3e to
2334d21
Compare
I gave the rebase a try. It looks like I got it right. Also squashed that typo.
tacaswell
tacaswell
approved these changes
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a shot at removing any checks for, or use of, ~/.matplotlib under linux. Motivated by discussion in issue #6885. Mainly just got rid of the check in init.py and some docstring stuff there. Also took a crack at updating the environment variable FAQ since it made reference to this stuff. Passed same tests as matplotlib/matplotlib/master did when running matplotlib.test().
@tacaswell mentioned having this for 2.1 but I'm not sure how to target a particular release. I'd be happy to try again if there's a way to do that explicitly on my end.