-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix captions for plot directive in latex target #6327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix captions for plot directive in latex target #6327
Conversation
@mdboom I think you are the only person around here how knows enough sphinx to review this.
That said, this seems reasonable to me and I am willing to believe @jarrodmillman that this works.
I submitted the changes upstream as well: matplotlib/matplotlib#6327
eb59744 to
a053ede
Compare
Hi @jarrodmillman,
Thanks for the patch!
Do you mind rebasing? This branch is a bit old...
Cheers,
N
a053ede to
89d2b85
Compare
@NelleV I've rebased. One test failed:
https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2668/job/s5uiy60v9mdioyty
But according to the log, it was a problem cloning the repo:
Build started
ECHO %PYTHON_VERSION% PYTEST=%USE_PYTEST% %CONDA_INSTALL_LOCN%
2.7 PYTEST=no C:\Miniconda
git clone -q https://github.com/matplotlib/matplotlib.git C:\projects\matplotlib
fatal: early EOF
fatal: The remote end hung up unexpectedly
fatal: index-pack failed
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
Command exited with code 128
python visual_tests.py
python: can't open file 'visual_tests.py': [Errno 2] No such file or directory
Command exited with code 2
It wasn't apparent to me how to get AppVeyor to try the build again.
89d2b85 to
9664046
Compare
I rebased again and now there is a different failure:
https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2694/job/4xtfn67it73jrf6p
Here is the complaint:
======================================================================
FAIL: matplotlib.tests.test_backend_pgf.test_pdflatex
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Miniconda\envs\test-environment\lib\site-packages\nose\case.py", line 197, in runTest
self.test(*self.arg)
File "c:\projects\matplotlib\lib\matplotlib\testing\decorators.py", line 150, in wrapped_callable
func(*args, **kwargs)
File "c:\projects\matplotlib\lib\matplotlib\testing\decorators.py", line 476, in backend_switcher
result = func(*args, **kwargs)
File "c:\projects\matplotlib\lib\matplotlib\tests\test_backend_pgf.py", line 106, in test_pdflatex
compare_figure('pgf_pdflatex.pdf', tol=0)
File "c:\projects\matplotlib\lib\matplotlib\tests\test_backend_pgf.py", line 49, in compare_figure
raise ImageComparisonFailure(err)
ImageComparisonFailure: Error: Image files did not match.
RMS Value: 14.0418635074
Expected:
C:\projects\matplotlib\result_images\test_backend_pgf\expected_pgf_pdflatex_pdf.png
Actual:
C:\projects\matplotlib\result_images\test_backend_pgf\pgf_pdflatex_pdf.png
Difference:
C:\projects\matplotlib\result_images\test_backend_pgf\pgf_pdflatex_pdf-failed-diff.png
Tolerance:
0
----------------------------------------------------------------------
Ran 6166 tests in 1671.759s
FAILED (KNOWNFAIL=37, SKIP=24, failures=1)
I took a look at pgf_pdflatex_pdf.png and expected_pgf_pdflatex_pdf.png. I doesn't appear the error was related to my modification of the Sphinx PDF template. However, I am not sure what happened.
I'll rebase again soon and see if the error persists.
Hi Jarrod,
The appveyor tests are very unreliable: I wouldn't worry too much about this.
Thanks for rebasing. I'll test on my computer tonight.
This looks good to me. 👍
@jarrodmillman by curiosity, do you use the plot directive in any projects?
Uh oh!
There was an error while loading. Please reload this page.
Builds on #4702