Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added missing implementation of get_window_extent for AxisImage and test (fixes #2980). #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelson merged 3 commits into matplotlib:master from maxalbert:fix_get_window_extent
Nov 30, 2014

Conversation

Copy link
Contributor

@maxalbert maxalbert commented Nov 29, 2014

No description provided.

Copy link
Member

Travis hiccup-ed. It needs a restart.

Copy link
Member

pelson commented Nov 29, 2014

Looking good. I'm going to let the tests finish, but I'm 👍.

Copy link
Member

pelson commented Nov 29, 2014

Looking good. I'm going to let the tests finish, but I'm 👍.

Spoke too soon. PEP8 test needs fixing (line too long)

Copy link
Member

Still has PEP8 issue

Copy link
Member

Should this be back-ported to 1.4.x?

Copy link
Member

======================================================================
FAIL: matplotlib.tests.test_coding_standards.test_pep8_conformance_installed_files
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 255, in test_pep8_conformance_installed_files
expected_bad_files=expected_bad_files)
File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 140, in assert_pep8_conformance
assert_equal(result.total_errors, 0, msg)
AssertionError: Found code syntax errors (and warnings):
/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/image.py:579:80: E501 line too long (83 > 79 characters)
----------------------------------------------------------------------
Ran 2 tests in 21.993s

pelson added a commit that referenced this pull request Nov 30, 2014
Added missing implementation of get_window_extent for AxisImage and test (fixes #2980).
@pelson pelson merged commit ca10a34 into matplotlib:master Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /