-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Remove lod #3834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lod #3834
Conversation
They do not seem to ever be used.
I thought @mdboom was planning on re-purposing it for rendering shortcuts
during interactivity?
On Sat, Nov 22, 2014 at 8:56 PM, Thomas A Caswell notifications@github.com
wrote:
You can merge this Pull Request by running
git pull https://github.com/tacaswell/matplotlib remove_lod
Or view, comment on, or merge it at:
#3834
Commit Summary
- MNT : remove set_lod and self._lod from Artist
- DOC : document removing lod
File Changes
- A doc/api/api_changes/2014-11-22-remove_lod.rst
https://github.com/matplotlib/matplotlib/pull/3834/files#diff-0 (7)- M lib/matplotlib/artist.py
https://github.com/matplotlib/matplotlib/pull/3834/files#diff-1 (13)Patch Links:
- https://github.com/matplotlib/matplotlib/pull/3834.patch
- https://github.com/matplotlib/matplotlib/pull/3834.diff
—
Reply to this email directly or view it on GitHub
#3834.
Fair enough. If that is the case I advocate still removing it now and adding it back with a more descriptive name.
Looks like this should have been merged 6 months ago... _lod dates back to 2004 and apparently has never been used. I'll merge it.
Removed an unsused setter and it's attribute from Artist.
There was no getter function.