-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Whats new cleaning #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whats new cleaning #3227
Conversation
doc/api/api_changes.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo at the end of this sentence. Also, I really think this should be coached carefully. I don't want to see a proliferation of gc.collect() calls by people prematurely optimizing. Perhaps a little bit of context would be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible we could just take out the second sentence altogether, unless there are true situations in which it is required/helps. I'm not sure there are, but maybe I'm just not aware of them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people who need it just know about it, so I am 👍 for removing that last sentence.
I probably should squash these down before it gets merged.
If you can squash these down, I'll merge.
@NelleV Done
Added missing whats_new and api_changes entries.