-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Backport PR #30394 on branch v3.10.x (ENH: Gracefully handle python-build-standalone ImportError with Tk) #30481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ksunden
merged 1 commit into
matplotlib:v3.10.x
from
meeseeksmachine:auto-backport-of-pr-30394-on-v3.10.x
Aug 29, 2025
Merged
Backport PR #30394 on branch v3.10.x (ENH: Gracefully handle python-build-standalone ImportError with Tk) #30481
ksunden
merged 1 commit into
matplotlib:v3.10.x
from
meeseeksmachine:auto-backport-of-pr-30394-on-v3.10.x
Aug 29, 2025
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaning towards merging over the flake8 warning for now (we no longer use flake8 on main, it did not trigger ruff on main, sooo). If that causes continued errors, may decide to fix it in a follow up, but looking to get 3.10.6 out.
Still going to let the other CI finish.
...ndalone ImportError with Tk
@QuLogic
QuLogic
force-pushed
the
auto-backport-of-pr-30394-on-v3.10.x
branch
from
August 28, 2025 19:27
20ac99b to
e1e1360
Compare
I just pushed the correction here; ruff is missing that rule...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #30394: ENH: Gracefully handle python-build-standalone ImportError with Tk