-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix: Inner circle rendering with log-scale + rorigin in polar plots (Fixes #30179) #30185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Inner circle rendering with log-scale + rorigin in polar plots (Fixes #30179) #30185
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this. I tried the example code given in the original issue, and this pull request does not solve the issue. Please could you update the pull request so that the issue is fixed, and verify this using the code posted in the original issue?
@bharshavardhanreddy924 do you plan to come back to this?
✅ Summary
Fixes: #30179
This pull request resolves a rendering issue in polar plots when using
set_yscale("log")
together withset_rorigin(...)
. Previously, when setting a custom radial origin in log scale, the inner circular gridline (representing the minimum radial value) would still be rendered at the center of the polar plot, rather than at the specified origin.This fix ensures correct rendering of the inner border with proper alignment to the configured
rorigin
, even under logarithmic radial scaling.🔧 What Was Changed?
projections/polar.py
by updating howrorigin
is applied whenlog
scale is used.📸 Visual Comparison
BeforeAfterFix
🧪 Minimal Code to Reproduce