-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Allow setting of aspect ratio for Axes in rcParams - Draft PR #30017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of aspect ratio for Axes in rcParams - Draft PR #30017
Conversation
I made a simple and basic implementation for this feature, before realising there was another draft request (#25642) open. Should I try to build off that Draft PR, or is my simple fix an ok starting point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only +0.1 on this. There's low need for it. A fixed aspect can never be part of a style because it only works reasonably when you know your data is in a similar aspect. I concede though, that it may be helpful on helper functions for custom plot types.
This should be introduced together with axes.adjustable.
This needs a "what's new entry - https://matplotlib.org/devdocs/users/next_whats_new/README.html
I've done some basic testing of the new implementation and it seems good. Apart from more complete testing, and adding a "What's New Entry", is there anything else to change or improve on?
** DRAFT PR **
closes #8088
Implementing feature that allows the setting of a default aspect ratio for axes, not just images. New features involves the addition of the rcParam: axes.aspect.
Below is a screenshot showing the feature in action (before the last couple of recent upstream commits were merged into the branch):
image