-
-
Notifications
You must be signed in to change notification settings - Fork 8k
[doc] minimally document what basic units is doing #29899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@story645
story645
changed the title
(削除) [doc] document what basic units is doing (削除ここまで)
(追記) [doc] minimally document what basic units is doing (追記ここまで)
Apr 10, 2025
@github-actions
github-actions
bot
added
the
Documentation: examples
files in galleries/examples
label
Apr 10, 2025
@story645
story645
force-pushed
the
doc-unit
branch
from
April 10, 2025 18:44
3706149 to
8968af5
Compare
@story645
story645
force-pushed
the
doc-unit
branch
from
April 10, 2025 18:53
8968af5 to
dc4ac69
Compare
timhoffm
timhoffm
approved these changes
Apr 10, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 10, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 10, 2025
Thanks, this puts it into perspective!
QuLogic
added a commit
that referenced
this pull request
Apr 11, 2025
...899-on-v3.10.1-doc Backport PR #29899 on branch v3.10.1-doc ([doc] minimally document what basic units is doing)
QuLogic
added a commit
that referenced
this pull request
Apr 11, 2025
...899-on-v3.10.x Backport PR #29899 on branch v3.10.x ([doc] minimally document what basic units is doing)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR summary
Going off the discussion in #28780, figured it'd be useful to add a sentence or two explaining that basic units is implementing a mini library so folks who don't need to can back out before trying to read the code.
PR checklist