-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix dead links in dev workflow docs #29463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to also have the commits from #29433 in this PR. While they are identical, the marge would go through, but please rebase so that it's clear these commits don't have anything to do with this PR.
On a side-note, please don't name PRs like Fixes #29305
. This is not easily understandable. Instead, use a semantic title like "Fix dead links in dev workflow docs". You should then add "Closes #29305" to the description. See also our Pull request guide. - I've adjusted this PR to conform with these rules.
I've tried to resolve the issue, but I guess the checks still didn't pass. I am open to all your suggestions, please guide me where I am doing things wrong since I am in my learning process :)
To fix the PR cleanliness check, you can squash the commits into one with an interactive rebase.
0f3104f
to
dfff9fd
Compare
Thankyou @rcomer for the help :)
I think you can also use interactive rebase to drop the "attach_note" commit.
For future PRs, you should create a separate feature branch, and then you don't get this problem.
Sure @rcomer I'll keep that in mind.
I am interested in contributing more to the project, it seems fascinating.. if you can help or guide me with more issues in any possible way I'd be grateful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't accept my review w/o first dropping the unrelated commit, but the article the
is missing
doc/devel/development_workflow.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I'll fix it
- Removed unnecessary sentence in the development workflow. - Fixed broken link in `development_workflow.rst`.
dfff9fd
to
bc68ad1
Compare
Uh oh!
There was an error while loading. Please reload this page.
PR summary
Closes #29305.
PR checklist