Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add quotes around [dev] in environment.yml #29243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@aishling-scilifelab aishling-scilifelab commented Dec 6, 2024 •
edited
Loading

Closes #29241 by improving the comment which explains how to up the dev environment using conda.

Update comment describing conda dev set up

  • Update commented commands in environment.yml to match
    the command in development_setup.rst
  • This version of the command does not cause issues with
    zsh (due to the quotation marks).

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

rcomer commented Dec 6, 2024

Hi @aishling-scilifelab thank you for your contribution! The command required to install in editable mode has changed since this was written. If you could update it to match the one described here, that would be great.
https://matplotlib.org/devdocs/devel/development_setup.html#install-matplotlib-in-editable-mode

aishling-scilifelab reacted with thumbs up emoji 

- Update commented commands in environment.yml to match
 the command in development_setup.rst
- This version of the command does not cause issues with
zsh (due to the quotation marks).
Copy link
Contributor Author

@rcomer Hey! Thanks - is the now pushed change what you mean?

Copy link
Member

rcomer commented Dec 6, 2024

@aishling-scilifelab looks good 👍

@aishling-scilifelab aishling-scilifelab marked this pull request as ready for review December 6, 2024 19:43
@timhoffm timhoffm added this to the v3.10.0 milestone Dec 7, 2024
@timhoffm timhoffm added the Documentation: devdocs files in doc/devel label Dec 7, 2024
@timhoffm timhoffm merged commit 671177c into matplotlib:main Dec 7, 2024
43 checks passed
Copy link
Member

timhoffm commented Dec 7, 2024

Thanks @aishling-scilifelab and congratulations on your first contribution to matplotlib! 🎉

QuLogic added a commit that referenced this pull request Dec 7, 2024 
...243-on-v3.10.x
Backport PR #29243 on branch v3.10.x (Add quotes around [dev] in environment.yml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Instructions for setting up conda dev environment in environment.yml give issues with MacOS/zsh

AltStyle によって変換されたページ (->オリジナル) /