-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Switch AxLine.set_xy{1,2} to take a single argument. #28933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
timhoffm
approved these changes
Oct 3, 2024
rcomer
rcomer
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one question. Everything else looks good to me, and I have learned some new tricks from this 👀
Also need to update the changenote file name.
@anntzer
anntzer
force-pushed
the
axlinexy
branch
from
October 3, 2024 16:24
737c716 to
9a4f9ac
Compare
Thanks, file renamed.
@anntzer
anntzer
force-pushed
the
axlinexy
branch
from
October 4, 2024 05:44
9a4f9ac to
1f7c55b
Compare
QuLogic
QuLogic
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #28800.
PR checklist