-
-
Notifications
You must be signed in to change notification settings - Fork 8k
DOC: Tell sphinx-gallery to link mpl_toolkits from our build #28632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
the
Documentation: build
building the docs
label
Aug 1, 2024
Otherwise, it will try to find it with intersphinx, and fail.
@QuLogic
QuLogic
force-pushed
the
fix-axes3d-links
branch
from
August 7, 2024 21:06
63ce151 to
f4e9ea5
Compare
The PR to sphinx-gallery is in, though not released yet.
story645
story645
approved these changes
Aug 7, 2024
timhoffm
timhoffm
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sphinx-gallery/sphinx-gallery#1363 is released via v0.17.1
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 9, 2024
...olkits from our build
timhoffm
added a commit
that referenced
this pull request
Aug 9, 2024
...632-on-v3.9.x Backport PR #28632 on branch v3.9.x (DOC: Tell sphinx-gallery to link mpl_toolkits from our build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Otherwise, it will try to find it with intersphinx, and fail.
Note that this needs sphinx-gallery/sphinx-gallery#1363 in order to work correctly (and that's currently patched in to the CI).
PR checklist