Amended Transcription #28579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ENUMERA8OR wants to merge 14 commits into matplotlib:main from ENUMERA8OR:main

Closed

Amended Transcription #28579

ENUMERA8OR wants to merge 14 commits into matplotlib:main from ENUMERA8OR:main

Conversation

ENUMERA8OR

Copy link

@ENUMERA8OR ENUMERA8OR commented Jul 15, 2024 •

edited

Loading

Amended transcription(spelling errors) in various & Moved the important dependency lines towards the very top of the file for better import in matplotlib/galleries/users_explain/quick_start.py

ENUMERA8OR added 4 commits

July 15, 2024 15:53

@ENUMERA8OR


 Update api_changes_1.5.0.rst

d36fb15

Amended transcription

@ENUMERA8OR


 Update api_changes_3.1.0.rst

eaa0d9e

Amended transcription

@ENUMERA8OR


 Update github_stats_3.3.0.rst

8fa663f

Amended transcription

@ENUMERA8OR


 Update github_stats_3.3.0.rst

79ca497

Amended transcription

@github-actions github-actions bot added Documentation: user guide Documentation: API labels

Jul 15, 2024

@ENUMERA8OR


 Update quick_start.py

f723934

Moved the important dependency lines towards the very top of the file for better import.

timhoffm

timhoffm reviewed

Jul 17, 2024

View reviewed changes

galleries/users_explain/quick_start.py Outdated

Comment on lines 16 to 17

import matplotlib.pyplot as plt

import numpy as np

Copy link

Member

@timhoffm timhoffm Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is input for a sphinx-gallery based tutorial. The module docstring provides the tutorial heading and imports should not be above that.

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

timhoffm

timhoffm reviewed

Jul 17, 2024

View reviewed changes

Copy link

Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

doc/users/prev_whats_new/github_stats_3.3.0.rst Show resolved Hide resolved

QuLogic

QuLogic reviewed

Jul 17, 2024

View reviewed changes

Copy link

Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the title of this PR is supposed to mean; please rename it to something descriptive.

doc/api/prev_api_changes/api_changes_3.1.0.rst Outdated Show resolved Hide resolved

ENUMERA8OR added 2 commits

July 22, 2024 02:56

@ENUMERA8OR


 Merge branch 'matplotlib:main' into main

ddea591

@ENUMERA8OR


 Update quick_start.py

c9d52e7

@ENUMERA8OR

Copy link

Author

ENUMERA8OR commented Jul 21, 2024

Made the changes please check...

@ENUMERA8OR


 Update api_changes_3.1.0.rst

deeb439

@ENUMERA8OR

Copy link

Author

ENUMERA8OR commented Aug 29, 2024

A call to maintainers, please check the changes.

tacaswell

tacaswell reviewed

Aug 29, 2024

View reviewed changes

doc/api/prev_api_changes/api_changes_3.1.0.rst Outdated

@@ -800,7 +800,7 @@ Changes in parameter names

`.bezier.split_bezier_intersecting_with_closedpath`,

``bezier.find_r_to_boundary_of_closedpath``,

`.bezier.split_path_inout` and `.bezier.check_if_parallel` has been renamed to

*tolerance*.

Copy link

Member

@tacaswell tacaswell Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tolerance is the spelling in the source, please drop this change, e.g.

matplotlib/lib/matplotlib/bezier.py

Lines 113 to 114 in b01462c

def find_bezier_t_intersecting_with_closedpath(

bezier_point_at_t, inside_closedpath, t0=0., t1=1., tolerance=0.01):

so this change needs to be reverted.

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

tacaswell

tacaswell reviewed

Aug 29, 2024

View reviewed changes

galleries/users_explain/quick_start.py Show resolved Hide resolved

QuLogic

QuLogic reviewed

Aug 30, 2024

View reviewed changes

doc/users/prev_whats_new/github_stats_3.3.0.rst Outdated

@@ -918,7 +918,7 @@ Pull Requests (1066):

* :ghpull:`16277`: Prefer using MouseButton to numeric values in docs and defaults.

* :ghpull:`16270`: numpydoc-ify SymLogNorm

* :ghpull:`16274`: Tiny cleanups to set_xlabel(..., loc=...).

* :ghpull:`16273`: DOC: Changing the spelling of co-ordinates.

* :ghpull:`16273`: DOC: Changing the spelling of coordinates.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for this one; the PR was updating the spelling, so the original is correct there.

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

ENUMERA8OR added 6 commits

September 8, 2024 02:11

@ENUMERA8OR


 Merge branch 'matplotlib:main' into main

320f852

@ENUMERA8OR


 Update bezier.py

c42cace

@ENUMERA8OR


 Update api_changes_3.1.0.rst

ea6082c

@ENUMERA8OR


 Update quick_start.py

53c44af

@ENUMERA8OR


 Update github_stats_3.3.0.rst

6b74bfb

@ENUMERA8OR


 Update api_changes_3.1.0.rst

f7409b0

ENUMERA8OR

ENUMERA8OR commented

Sep 17, 2024

View reviewed changes

Copy link

Author

@ENUMERA8OR ENUMERA8OR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved as per maintainers suggestions

A call to maintainers, please check the changes.

doc/users/prev_whats_new/github_stats_3.3.0.rst Show resolved Hide resolved

doc/users/prev_whats_new/github_stats_3.3.0.rst Outdated

@@ -918,7 +918,7 @@ Pull Requests (1066):

* :ghpull:`16277`: Prefer using MouseButton to numeric values in docs and defaults.

* :ghpull:`16270`: numpydoc-ify SymLogNorm

* :ghpull:`16274`: Tiny cleanups to set_xlabel(..., loc=...).

* :ghpull:`16273`: DOC: Changing the spelling of co-ordinates.

* :ghpull:`16273`: DOC: Changing the spelling of coordinates.

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

galleries/users_explain/quick_start.py Outdated

Comment on lines 16 to 17

import matplotlib.pyplot as plt

import numpy as np

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

doc/api/prev_api_changes/api_changes_3.1.0.rst Outdated

@@ -800,7 +800,7 @@ Changes in parameter names

`.bezier.split_bezier_intersecting_with_closedpath`,

``bezier.find_r_to_boundary_of_closedpath``,

`.bezier.split_path_inout` and `.bezier.check_if_parallel` has been renamed to

*tolerance*.

Copy link

Author

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@ENUMERA8OR

Copy link

Author

ENUMERA8OR commented Sep 17, 2024 •

edited

Loading

A call to maintainers please check. @tacaswell @QuLogic @timhoffm @jiahao

@melissawm

Copy link

Member

melissawm commented Oct 15, 2024

Hi @ENUMERA8OR , it seems like there are a number of failing tests and linting checks that need to be resolved here - addressing these first will help with getting reviews.

Also, as suggested above, changing the title of your PR to be more descriptive instead of "Amended Transcription" might also help.

Cheers!

timhoffm

timhoffm reviewed

Oct 16, 2024

View reviewed changes

doc/api/prev_api_changes/api_changes_3.1.0.rst

@@ -795,7 +795,7 @@ Changes in parameter names

- The *normed* parameter to `.Axes.hist2d` has been renamed to *density*.

- The *s* parameter to `.Annotation` (and indirectly `.Axes.annotate`) has

been renamed to *text*.

- The *tolerence* parameter to

- The ** parameter to

Copy link

Member

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a revert gone wrong. The old parameter name was tolerence and we need to keep it exactly spelled like it was before the change.

doc/users/prev_whats_new/github_stats_3.3.0.rst

@@ -254,7 +254,7 @@ Pull Requests (1066):

* :ghpull:`17617`: Rewrite pdf test to use check_figures_equal.

* :ghpull:`17654`: Small fixes to recent What's New

* :ghpull:`17649`: MNT: make _setattr_cm more forgiving

* :ghpull:`17644`: Doc 33 whats new consolidation

* :ghpull:`17644`: Doc 33 what's new consolidation

Copy link

Member

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before I would like to keep all PR titles exactly as they are, including any spell errors.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already went and fixed the PR titles, so these are fine, if a bit overzealous. Only the "tolerence" one should stay as it was as it is intentional.

lib/matplotlib/bezier.py

@@ -111,7 +111,7 @@ def split_de_casteljau(beta, t):

def find_bezier_t_intersecting_with_closedpath(

bezier_point_at_t, inside_closedpath, t0=0., t1=1., tolerance=0.01):

bezier_point_at_t, inside_closedpath, t0=0., t1=1., tolerence=0.01):

Copy link

Member

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot simply rename parameters in public functions, because this will break user code. Such a change has to go through a deprecation process. We could to this, but it's a separte topic that should be handled in a dedicated PR.

doc/api/prev_api_changes/api_changes_1.5.0.rst

@@ -189,7 +189,7 @@ algorithm that was not necessarily applicable to custom Axes. Three new private

methods, ``matplotlib.axes._base._AxesBase._get_view``,

``matplotlib.axes._base._AxesBase._set_view``, and

``matplotlib.axes._base._AxesBase._set_view_from_bbox``, allow for custom

*Axes* classes to override the pan and zoom algorithms. Implementors of

*Axes* classes to override the pan and zoom algorithms. Implementers of

Copy link

Member

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the only viable direct change here.

@ENUMERA8OR ENUMERA8OR closed this by deleting the head repository

Nov 13, 2024

Labels

Documentation: API Documentation: user guide

5 participants

@ENUMERA8OR @melissawm @tacaswell @QuLogic @timhoffm

Uh oh!

Amended Transcription #28579

Amended Transcription #28579

Uh oh!

Conversation

@ENUMERA8OR ENUMERA8OR commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@timhoffm timhoffm Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ENUMERA8OR commented Jul 21, 2024

Uh oh!

ENUMERA8OR commented Aug 29, 2024

Uh oh!

@tacaswell tacaswell Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@QuLogic QuLogic Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

@ENUMERA8OR ENUMERA8OR Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

ENUMERA8OR commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melissawm commented Oct 15, 2024

Uh oh!

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

@QuLogic QuLogic Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

@timhoffm timhoffm Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@ENUMERA8OR ENUMERA8OR commented Jul 15, 2024 •

edited

Loading

ENUMERA8OR commented Sep 17, 2024 •

edited

Loading