-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Update return type for Axes.axhspan and Axes.axvspan #28423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. There are some CI failures but they are also showing in other PRs and clearly not related to documentation or typing so I am not worried about them.
Thank you for your contribution @chrille0313 and congratulations on your first PR in Matplotlib! I hope we hear from you again.
...423-on-v3.9.x Backport PR #28423 on branch v3.9.x (Update return type for Axes.axhspan and Axes.axvspan)
PR summary
As explained in #28417, the implementation of Axes.axhspan and Axes.axvspan return Rectangles instead of Polygons as of v3.9.0. This PR updates the return type of these methods.
closes #28417
PR checklist