-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix marker validator with cycler (allow mix of classes) #27613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, can you please add a test?
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Please add the following to the rcsetup.pyi file (Should be in roughly the same order as the .py file):
def validate_marker(s: Any) -> int | string: ... def validate_markerlist(s: Any) -> list[int | string]: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures unrelated
@faisal-fawad we typically prefer changes be squashed down to a few commits - would you have interest in squashing down to 1 commit or would you like us to do so?
@story645 If you could handle it for this PR that would be preferred.
If you don't mind me asking, how could I squash the commits myself for future PRs?
There are a few extra changes here; make sure you use a force push after rebasing.
f6e22f8 to
8bcac52
Compare
Add test Add stubs Private functions & updated test Update test Co-authored-by: Kyle Sunden <git@ksunden.space> Add test Private functions & updated test
8bcac52 to
8ca4d79
Compare
Thanks @faisal-fawad! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.
Uh oh!
There was an error while loading. Please reload this page.
PR summary
Closes #27596. Added basic support for combination of strings and integers to satisfy expected behavior.
PR checklist