-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Update ax.legend input types #27535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update ax.legend input types #27535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rcomer
rcomer
changed the title
(削除) Update legend input types (削除ここまで)
(追記) Update ax.legend input types (追記ここまで)
Dec 17, 2023
timhoffm
timhoffm
approved these changes
Dec 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 18, 2023
ksunden
added a commit
that referenced
this pull request
Dec 18, 2023
...535-on-v3.8.x Backport PR #27535 on branch v3.8.x (Update ax.legend input types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #27507 by changing the annotations for handles and labels to
Iterable, as requested. In addition to the discussion there, I just realised we already have it like this forfig.legendmatplotlib/lib/matplotlib/figure.pyi
Lines 129 to 133 in 2e95cf2
Also changes the handles type to list in the
ax.legenddocstring, following the guidelines. This is now consistent with the labels type in this docstring and with the fig.legend docstring.PR checklist