-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Bump actions/stale from 8 to 9 #27495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Based on those release notes, I think we may wish to bump down the number we process per run...
I'm tempted to suggest going significantly down to start with and ramping back up to approximately the level we have now where ~10 things get flagged per run usually.
Thoughts? In particular, @rcomer I know you have adjusted that number a few times.
Agreed, since the action will no longer start from the oldest issue and work forward but start from where it finished last time, if we leave the operations limit as it is now we will get far too many new labels on each run. To add a new label, the action uses up four operations. So I suggest we decide the maximum number of new labels we want on a run (five?) and multiply that by 4 to set the operations-per-run
.
I think this also means that, once the new labels are added, those issues won't be re-checked until the action has worked through all ~1500 open issues and PRs. That is clearly going to take a long time, so the action won't be removing the label (if someone posts a new comment) or closing issues after a month. I wonder if we could have a second workflow using the same action that only does these cleanup steps. Would that work? Would it be overkill?
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore
condition with the desired update_types
to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps actions/stale from 8 to 9.
Release notes
Sourced from actions/stale's releases.
Changelog
Sourced from actions/stale's changelog.
... (truncated)
Commits
28ca103
Upgrade Node to v20 (#1110)b69b346
build(deps-dev): bump@types/node
from 18.16.18 to 20.5.1 (#1079)88a6f4f
build(deps-dev): bump typescript from 5.1.3 to 5.2.2 (#1083)796531a
Merge pull request #1080 from akv-platform/fix-delete-cache8986f62
Don not try to delete cache if it does not existscab99b3
fix typo proceeded/processed184e7af
Merge pull request #1064 from actions/dependabot/npm_and_yarn/typescript-esli...523885c
chore: update eslint-plugin, parser and eslint-plugin-jest2487a1d
build(deps-dev): bump@typescript-eslint/eslint-plugin
60c722e
Merge pull request #1063 from actions/dependabot/npm_and_yarn/jest-29.6.2Dependabot compatibility score
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)