-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Added test_fill_betweenx in test_datetime.py #27425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thank you. I believe that one can probably skip the second subplot since that is only using floats (so not really related to the purpose of the test).
Thank you. I believe that one can probably skip the second subplot since that is only using floats (so not really related to the purpose of the test).
Hi, I did that because both "axes.fill" and "axes.fill_between" did that as well for a comparison. I think it can be consistent if I keep this, but I can also remove it if you think it is unnecessary
@xieruoyi Oscar raised the same objection to fill_between and it was removed before it was merged.
I agree that it should likely be removed, though I did in fact ignore that for fill, its not exactly harming anything, just isn't the objective of the test.
image
Hi, I changed it, thank you for pointing out!
PR summary
Added code for test_fill_betweenx in test_datetime.py as requested in #26864
Image for an output
image
PR checklist