-
-
Notifications
You must be signed in to change notification settings - Fork 8k
DOC: add collection-fontsrecommended to dependencies #27282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you tell from the error messages which font was missing? The packaging of latex stuff seems to vary significantly between ecosystem, could you also add a note which distro this naming is from?
could you also add a note which distro this naming is from?
Texlive - this is using tlmgr, (ETA) but I'll clarify that it's a texlive package. Different distros have it too
And all I got from the error messages was that fonts were just being very wonky (It probably didn't help that I forgot to rebuild the font-cache after installing a new font)
These are the types of errors I got though:
rewrote to make clearer this is a latex distro packaging requirement
You can find an exact list at https://src.fedoraproject.org/rpms/python-matplotlib/blob/rawhide/f/python-matplotlib.spec#_95 though that's probably far too specific to list for users. But you might be able to convert those into the collections.
Can I say that's out of scope for this PR and turn it into a good first issue for someone else?
ae2b8fb
to
2e5c996
Compare
2e5c996
to
3806e23
Compare
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
fd07984
to
978fd77
Compare
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.8.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 5ee79b7d81f0c9ea9dcba69c5e8cac35f7d1c183
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27282: DOC: add collection-fontsrecommended to dependencies'
- Push to a named branch:
git push YOURFORK v3.8.x:auto-backport-of-pr-27282-on-v3.8.x
- Create a PR against branch v3.8.x, I would have named this PR:
"Backport PR #27282 on branch v3.8.x (DOC: add collection-fontsrecommended to dependencies)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport
label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.8.2-doc
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 5ee79b7d81f0c9ea9dcba69c5e8cac35f7d1c183
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27282: DOC: add collection-fontsrecommended to dependencies'
- Push to a named branch:
git push YOURFORK v3.8.2-doc:auto-backport-of-pr-27282-on-v3.8.2-doc
- Create a PR against branch v3.8.2-doc, I would have named this PR:
"Backport PR #27282 on branch v3.8.2-doc (DOC: add collection-fontsrecommended to dependencies)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport
label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
My latex and fonts have imploded and started deleting themselves and doing a minimal texlive install, I also needed ``collection-fontsrecommended` for the docs to not error out.