Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Formatted release note docs #27039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 1 commit into matplotlib:main from Gaurav-Kumar-Soni:formatting
Oct 17, 2023
Merged

Conversation

Copy link
Contributor

@Gaurav-Kumar-Soni Gaurav-Kumar-Soni commented Oct 9, 2023

PR summary

Reformatted the release notes as per the style conventions at https://matplotlib.org/devdocs/devel/document.html#section-formatting.

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

story645 commented Oct 9, 2023

Thanks for the PR!

In #26862 I put the release files on the please don't format list because I'm not sure if their formatting is historical artifact or due to how released - @QuLogic or @ksunden do you know?

Copy link
Member

QuLogic commented Oct 11, 2023

These files are fine, but it depends on if it breaks all the files in their toctrees.

Copy link
Member

Was looking at the built docs and didn't seem to but I may be missing something

Gaurav-Kumar-Soni reacted with eyes emoji

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna leave merging for a bit in case @QuLogic has an objection but looks good to me.

Copy link
Contributor Author

Okie ..

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed good to me on a quick look through things.

@QuLogic QuLogic added this to the v3.8.1 milestone Oct 17, 2023
@QuLogic QuLogic merged commit 978b402 into matplotlib:main Oct 17, 2023
@QuLogic QuLogic changed the title (削除) Formatted docs (削除ここまで) (追記) Formatted release note docs (追記ここまで) Oct 17, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 17, 2023
Copy link
Member

QuLogic commented Oct 17, 2023

Thanks @Gaurav-Kumar-Soni! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Gaurav-Kumar-Soni, muneeb-i-khan, and cyberphantom52 reacted with heart emoji

ksunden added a commit that referenced this pull request Oct 17, 2023
...039-on-v3.8.x
Backport PR #27039 on branch v3.8.x (Formatted docs)
@ksunden ksunden mentioned this pull request Nov 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 approved these changes

Assignees
No one assigned
Projects
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /