-
-
Notifications
You must be signed in to change notification settings - Fork 8k
add test_plot_date in test_datetime.py #27037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test_plot_date in test_datetime.py #27037
Conversation
Hi @kots14, thanks for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to plot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.
(For reference, it only does anything beyond plot if xdate=True or ydate=True are passed, at which point it sets the units of the axis)
A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to
plot(and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.(For reference, it only does anything beyond
plotifxdate=Trueorydate=Trueare passed, at which point it sets the units of the axis)
Should I include additional tests to accommodate this in the same test? Please suggest.
I'd say this is fine for this test file. If anything, I think I'd move towards actually deprecating this method, as it's been soft-deprecated (i.e. discouraged in the docstring, but not warning at runtime) since 3.5.
The date plotting parts of this method are already tested in test_axes.py (as full image comparison tests, so even more rigorous than we are wanting here initially).
PR summary
Adding code for
test_plot_datemethod intest_datetime.pymentioned in #26864Image output -
test_plot_date_image
PR checklist