-
-
Notifications
You must be signed in to change notification settings - Fork 8k
ValueError exception added to handle mix of {} and % string in colorbar format #27015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
timhoffm
reviewed
Oct 6, 2023
timhoffm
timhoffm
approved these changes
Oct 6, 2023
We do prefer rebases over merges, if you can do so.
@borgesaugusto
borgesaugusto
force-pushed
the
iss_27007
branch
from
October 8, 2023 08:32
b66d739 to
10b4157
Compare
rcomer
rcomer
approved these changes
Oct 8, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 8, 2023
...x of {} and % string in colorbar format
Thanks @borgesaugusto and congratulations on your first PR merged into Matplotlib! Your other one should be merged soon (just waiting for the tests to pass). I hope we hear from you again.
rcomer
added a commit
that referenced
this pull request
Oct 8, 2023
...015-on-v3.8.x Backport PR #27015 on branch v3.8.x (ValueError exception added to handle mix of {} and % string in colorbar format)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Addresses issue #27007 . If the try/except is done inversely, the error happens in the other block, but the edge case is formatted correctly. Then, both exceptions (TypeError and ValueError) will use the StrMethodFormatter.
The test is created separetly from test_colorbar_format() (L615) to make it clearer.
PR checklist