Hi @Vashesh08 , it looks like you pulled in a number of unrelated commits into your branch. You will probably need to rebase your branch to leave only your commits. If you run into trouble and need help, let us know.

@melissawm I think I removed the unrelated commits. Thanks for the docs!

I'm extremely sorry for the delay in responding. I missed out on your response.

The primary concern I had was how should I tackle the hatchcolor when both hatchcolor and edgecolor values both are specified. Since these values are updating using _internal_update method, which makes the order of these parameters important. In order to tackle this, I had to introduced a class variable self.set_hatch_color and local function variables set_hatchcolor_from_edgecolor.

the hatchcolor shouldn't be set inside edgecolor
I think the way this would have to be done would be passing an additional parameter to set_hatchcolor function. Although that would make a redundant variable but I think it would clean up the logic.

I will be pushing these changes. Lmk if you still think there are room for any more improvements.

hi, we discussed this on the call this week b/c I was worried and @ksunden and @QuLogic both suggested that there's a way to inherit the rcparam from edgecolor so that you can reduce the fallback logic and that legend.facecolor already tracks legend.edgecolor and you can maybe use that as a model. What that means is it solves the black default or intentional problem so

• setting hatch.color to 'inherit'

  • needs an API behavior note probably
  • https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/mpl-data/matplotlibrc#L534

  • matplotlib/lib/matplotlib/rcsetup.py

    Line 1175 in 5e34777

    "legend.facecolor": validate_color_or_inherit,

• use legend.facecolor tracking legend.edgecolor as model:

  • matplotlib/lib/matplotlib/legend.py

    Lines 532 to 538 in 5e34777

    facecolor = mpl._val_or_rc(facecolor, "legend.facecolor")

    if facecolor == 'inherit':

    facecolor = mpl.rcParams["axes.facecolor"]

    edgecolor = mpl._val_or_rc(edgecolor, "legend.edgecolor")

    if edgecolor == 'inherit':

    edgecolor = mpl.rcParams["axes.edgecolor"]

• include hatches in set_alpha color changes b/c setting alpha after setting edgecolor will overwrite current,

  • needs an API behavior note

• Check for parallel behavior, if possible, between Patch and Collection since both have hatches.

Also thanks for your patience and perseverance on this.