-
-
Notifications
You must be signed in to change notification settings - Fork 8k
ci: Don't install recommended packages on Ubuntu #26505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking through the results it seems that everything is good. There's just a failure of some font tests because of an outdated cache.
We don't need the optional packages and save a little download/install time.
@QuLogic
QuLogic
force-pushed
the
gha-update
branch
from
August 14, 2023 17:10
f708687 to
c774216
Compare
ksunden
ksunden
approved these changes
Aug 14, 2023
story645
story645
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if you want this squash merged or regular merged so leaving it for you to self merge.
I'll always prefer regular merge.
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR summary
We don't need the optional packages and can save a little download/install time.
Also, update the WQY ZenHei package name, as apt has been noting it's outdated for a while.
Draft because I need to confirm that we actually don't need any optional things.
PR checklist