-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix get_constrained_layout_pads #25964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_constrained_layout_pads #25964
Conversation
- fix non-existing function get_info() - complete docs
6cb2d8d to
67d1126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone can merge on green.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
d92c1b7 to
b45d2c4
Compare
Oops, I messed up the types there, should be fixed now.
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.7.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1c8975abd03478713c2e4a878fd69629e96c20b9
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25964: Fix get_constrained_layout_pads'
- Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25964-on-v3.7.x
- Create a PR against branch v3.7.x, I would have named this PR:
"Backport PR #25964 on branch v3.7.x (Fix get_constrained_layout_pads)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
...3.7.x Backport PR #25964 on branch v3.7.x (Fix get_constrained_layout_pads)
PR summary
get_info()closes #25963
PR checklist