-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New layout for qt4 subplottool + QMainWindow -> QDialog #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tacaswell rebased + use new style qt signals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only have this one other place in the code base, is there a policy on this? @mdboom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 occurrences of __author__ in the mpl codebase
examples/api/sankey_demo_old.py:__author__ = "Yannick Copin <ycopin@ipnl.in2p3.fr>" examples/user_interfaces/interactive.py:__author__ = "Fernando Perez <Fernando.Perez@colorado.edu>" examples/user_interfaces/svg_histogram.py:__author__="david.huard@gmail.com" lib/matplotlib/sankey.py:__author__ = "Kevin L. Davies"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue that the examples are not part of the library proper (as they are stand alone examples of using the library)
@Thisch Awesome, thanks!
I am a little concerned about two non-code things (both of which may be me worrying too much):
- @rhoef has been cut out of the commit logs entirely. Fixing that would require completely re-writing history to replace the first commit of this branch with a squashed version of the New subplottool and various fixes #2112 branch.
- What is the license on files created with
pyuic? I think it is clean, but IANAL.
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
@tacaswell: Put @rhoef back into the commit logs (by squashing the #2112 branch)
I just tested this quickly on my machine, and it looks very nice. Just one glitch: the label on the "tight layout" button is misspelled (starts with "th" instead of "t").
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
@efiring fixed typo
New layout for qt4 subplottool + QMainWindow -> QDialog
This supersedes the subplottool part from #2112.