-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add Figure methods get_suptitle(), get_subxlabel(), get_supylabel() #25686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@timhoffm
timhoffm
force-pushed
the
get_suptitle
branch
from
April 14, 2023 21:36
8526106 to
0d3fda5
Compare
jklymak
jklymak
reviewed
Apr 14, 2023
QuLogic
QuLogic
approved these changes
Apr 15, 2023
oscargus
oscargus
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We had no public API to optain these values. The API is modelled analogous to
Axes.get_title()/Axes.get_x/ylabel(), i.e. returning a string (and not the Text object) and returning an empty string if no text has been set yet.Side remark. It's historic and unfortunate that the setters don't have the
set_prefix (in contrast to e.g.set_title()). Neverthelessget_*is the only sane choice for the getters introduced here.