Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix issue #25458 by changing "normed" to "density" in documentation #25461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcomer merged 1 commit into matplotlib:main from ColeBurch:issue25458
Mar 14, 2023

Conversation

Copy link
Contributor

@ColeBurch ColeBurch commented Mar 14, 2023
edited
Loading

PR Summary

Closes #25458

Changes "normed" in the documentation to "density" due to the parameter being renamed in v3.3

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

rcomer reacted with rocket emoji
Copy link
Member

rcomer commented Mar 14, 2023
edited
Loading

Thanks @ColeBurch that was quick! Could you edit your original post to include a description of the change, and also "Closes #25458"? The change itself looks good to me 👍

Copy link
Contributor Author

Thanks @rcomer, I edited my original post to include a description and the issue close comment in the PR summary section.

rcomer reacted with thumbs up emoji

@rcomer rcomer merged commit 11c51fe into matplotlib:main Mar 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2023
Copy link
Member

rcomer commented Mar 14, 2023

Thanks @ColeBurch and congratulations on your first PR! 🎉 We hope to hear from you again.

@ColeBurch ColeBurch deleted the issue25458 branch March 14, 2023 19:19
ksunden added a commit that referenced this pull request Mar 14, 2023
...461-on-v3.7.1-doc
Backport PR #25461 on branch v3.7.1-doc (Fix issue #25458 by changing "normed" to "density" in documentation)
ksunden added a commit that referenced this pull request Mar 14, 2023
...461-on-v3.7.x
Backport PR #25461 on branch v3.7.x (Fix issue #25458 by changing "normed" to "density" in documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Projects
Milestone
v3.7-doc
Development

Successfully merging this pull request may close these issues.

[Doc]: possible typo in example: "Using histograms to plot a cumulative distribution"
2 participants

AltStyle によって変換されたページ (->オリジナル) /