-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Re-enable CI buildwheel and cygwin labels #25236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies - I renamed this; I had no idea it was being used for a workflow. Alternative is to change the name back. Note I also changed the Cygwin name.
Perhaps in the description, we can be more draconian: "DON'T RENAME AS IT BREAKS AN ACTION" ?
While you are doing this can you fix the cgywn one as well?
I also wonder if in the GHA it is possible to grab the label id rather than the name (which should be stable over time!)?
579f66f to
cb89168
Compare
Added Cygwin as well.
Couldn't figure out which members are available for the events...
Probably this should be backported? Thinking that otherwise one cannot do this for backported PRs? Like the qhull LICENSE issue?
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.7.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 60f01751c0bfb486dec45faf1c494e4c1042f236
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25236: Re-enable CI buildwheel and cygwin labels'
- Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25236-on-v3.7.x
- Create a PR against branch v3.7.x, I would have named this PR:
"Backport PR #25236 on branch v3.7.x (Re-enable CI buildwheel and cygwin labels)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Re-enable CI buildwheel and cygwin labels Note: cygwin ci does not exist on v3.7.x, so cygwin changes are omitted (cherry picked from commit 60f0175)
Cygwin ci does not exist for 3.7.x, so the changes to cygwin are not backported
...3.7.x Backport PR #25236: Re-enable CI buildwheel and cygwin labels
PR Summary
I guess this was renamed recently?
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst